Inline event handlers refactoring #551
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swissspidy
reviewed
Sep 24, 2020
swissspidy
reviewed
Sep 24, 2020
| wp_die( $api->get_error_message() . '</p> <p><a href="#" onclick="document.location.reload(); return false;">' . __( 'Try Again' ) . '</a>' ); | ||
| wp_die( $api->get_error_message() . '</p> <p><a href="#" id="theme-try-again">' . __( 'Try Again' ) . '</a>' ); | ||
|
|
||
| $js = <<<'JS' |
Member
There was a problem hiding this comment.
I assume this can't be in an external file?
Author
There was a problem hiding this comment.
I couldn't find instances of this method being used, so I moved the handler to an inline script for simplicity.
swissspidy
reviewed
Sep 24, 2020
swissspidy
reviewed
Sep 24, 2020
swissspidy
reviewed
Sep 24, 2020
swissspidy
reviewed
Sep 24, 2020
swissspidy
reviewed
Sep 24, 2020
swissspidy
reviewed
Sep 25, 2020
swissspidy
reviewed
Sep 25, 2020
Ayesh
reviewed
Sep 30, 2020
swissspidy
reviewed
Oct 5, 2020
swissspidy
reviewed
Oct 5, 2020
f6bfa19 to
ec4f41d
Compare
vrana
reviewed
Oct 8, 2020
dbdef78 to
43b4fac
Compare
cfddf14 to
f67e4ba
Compare
75d9ecd to
c2550c2
Compare
…dit-form-advanced.php`.
…dmin-header.php`.
…dmin-footer.php`.
…s/functions.php`.
…mage-header.php` with event handler in `js/_enqueues/admin/custom-header.js`.
…h event handler in `js/_enqueues/admin/edit-comments.js`.
…t-table.php` with event handler in `js/_enqueues/admin/link-manager.js`.
…es/meta-boxes.php` with event handler in `src/js/_enqueues/admin/link.js`.
…t-table.php` with event handler in `js/_enqueues/admin/media.js`.
…h event handler in `js/_enqueues/admin/post.js`.
…t handler in `js/_enqueues/admin/setup-config.js`.
…st-table.php` with event handler in `js/_enqueues/admin/themes-list.js`.
…` and `src/wp-admin/includes/post.php` with event handler in `wp-includes/js/metabox-events.js`.
…enus.php` with event handler in `js/_enqueues/wp/customize/nav-menus.js`.
…u-widget.php` with event handler in `js/_enqueues/wp/customize/widgets.js`.
…tall-list-table.php` with event handler in inline script.
… event handler in inline script.
…th event handler in inline script.
…handler in inline script.
…t handler in inline script.
…` with event handler in `js/_enqueues/lib/image-edit.js`.
…ent handler in `js/_enqueues/admin/media-events.js`.
…includes/ms.php` with event handler in `js/_enqueues/admin/common.js`.
…dmin/plugin-editor.php` with event handler in `js/_enqueues/wp/theme-plugin-editor.js`.
c2550c2 to
311cf6a
Compare
3 tasks
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trac ticket: https://core.trac.wordpress.org/ticket/51407
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.