Remove suffix from converted full size images.#7748
Conversation
Co-authored-by: Peter Wilson <519727+peterwilsoncc@users.noreply.github.com>
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
…uffix-converted-img-type
felixarntz
left a comment
There was a problem hiding this comment.
@peterwilsoncc This looks great to me, thanks for working on this.
I have one question, but I trust the tests passing over my question, so I'll already approve.
|
Just tested this again (manually) and all seems to work properly.
|
ironprogrammer
left a comment
There was a problem hiding this comment.
Thanks, @peterwilsoncc! Just a couple quick nits here.
mukeshpanchal27
left a comment
There was a problem hiding this comment.
Thanks @peterwilsoncc
Co-authored-by: Brian Alexander <824344+ironprogrammer@users.noreply.github.com>
mukeshpanchal27
left a comment
There was a problem hiding this comment.
Nit-pick. Not blocking add end period in message.
Co-authored-by: Mukesh Panchal <mukeshpanchal27@users.noreply.github.com>
Remove the dimension suffix from the full size image when converted to a web safe type.
This prevents the full size image file names from having the same form as a sub-sized image,
filename-widthxheight.ext. Instead the file name uses the original name with the new extension.Includes tests from #7733 but modified to use HEIC for the conversion source.
Trac ticket: Core-62359