Skip to content

Use native img by default#6805

Merged
westonruter merged 2 commits into
developfrom
update/native-img-by-default
Mar 14, 2022
Merged

Use native img by default#6805
westonruter merged 2 commits into
developfrom
update/native-img-by-default

Conversation

@westonruter

@westonruter westonruter commented Dec 22, 2021

Copy link
Copy Markdown
Member

Summary

With amp-img being deprecated in favor of native img (ampproject/amphtml#30442), we can now finally stop using amp-img by default.

Depends on #6803.

Checklist

  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@westonruter westonruter added this to the v2.3 milestone Dec 22, 2021
@westonruter westonruter force-pushed the update/native-img-by-default branch from 77120c0 to 24f0658 Compare December 22, 2021 01:43
@westonruter westonruter added the P0 High priority label Dec 23, 2021
Base automatically changed from update/amphtml-2112102136000 to develop March 3, 2022 04:47
@westonruter westonruter force-pushed the update/native-img-by-default branch from 24f0658 to e9714ba Compare March 11, 2022 17:32
Comment thread includes/sanitizers/class-amp-style-sanitizer.php
@westonruter westonruter marked this pull request as ready for review March 14, 2022 18:02
@github-actions

Copy link
Copy Markdown
Contributor

Plugin builds for cca6c8e are ready 🛎️!

@westonruter

Copy link
Copy Markdown
Member Author

Merging this so it can soak in develop for a while to ensure it is fully baked.

@pooja-muchandikar

Copy link
Copy Markdown

Compared the changes of this PR and PR #7066 and found that the changes are done as per PR #7066.

And the changes are working as per #7066

By default amp-img is displayed and based on the toggle native img will be used. #7035 (comment)

@westonruter westonruter added the Changelogged Whether the issue/PR has been added to release notes. label Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Changelogged Whether the issue/PR has been added to release notes. P0 High priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants