Skip to content

Replace use of dangerouslySetInnerHTML with createInterpolateElement#7000

Merged
westonruter merged 7 commits into
developfrom
enhancement/remove-dangerouslySetInnerHTML
Apr 20, 2022
Merged

Replace use of dangerouslySetInnerHTML with createInterpolateElement#7000
westonruter merged 7 commits into
developfrom
enhancement/remove-dangerouslySetInnerHTML

Conversation

@dhaval-parekh

@dhaval-parekh dhaval-parekh commented Mar 28, 2022

Copy link
Copy Markdown
Collaborator

Summary

Fixes #6759

Replace use of dangerouslySetInnerHTML with createInterpolateElement

Checklist

  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@dhaval-parekh dhaval-parekh marked this pull request as ready for review March 28, 2022 07:20
@westonruter westonruter added this to the v2.2.3 milestone Mar 29, 2022
@westonruter westonruter modified the milestones: v2.2.3, v2.2.4, 2.2.5 Apr 6, 2022
@maitreyie-chavan maitreyie-chavan modified the milestones: v2.2.5, v2.3 Apr 14, 2022
@milindmore22

Copy link
Copy Markdown
Collaborator

@dhaval-parekh please resolve merge conflicts

@dhaval-parekh dhaval-parekh force-pushed the enhancement/remove-dangerouslySetInnerHTML branch from bc7198a to 1e9bf82 Compare April 19, 2022 12:11
@github-actions

github-actions Bot commented Apr 19, 2022

Copy link
Copy Markdown
Contributor

Plugin builds for e3134fd are ready 🛎️!

@lgtm-com

lgtm-com Bot commented Apr 19, 2022

Copy link
Copy Markdown

This pull request introduces 1 alert when merging 1e9bf82 into 326d057 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@milindmore22 milindmore22 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@westonruter westonruter left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A great improvement! Just a couple nits to address.

Comment thread assets/src/components/amp-support/index.js
Comment thread assets/src/components/template-mode-option/index.js
Comment thread assets/src/onboarding-wizard/pages/template-mode/index.js Outdated
Comment thread assets/src/settings-page/analytics.js Outdated
Comment thread assets/src/settings-page/analytics.js Outdated
Comment thread assets/src/settings-page/plugin-suppression.js
@westonruter

westonruter commented Apr 19, 2022

Copy link
Copy Markdown
Member

BTW: PR 7,000 🎉

@westonruter westonruter left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I love it.

@westonruter westonruter merged commit 724a933 into develop Apr 20, 2022
@westonruter westonruter deleted the enhancement/remove-dangerouslySetInnerHTML branch April 20, 2022 16:59
@westonruter westonruter added the Changelogged Whether the issue/PR has been added to release notes. label Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Changelogged Whether the issue/PR has been added to release notes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace dangerouslySetInnerHTML with createInterpolateElement in React apps

4 participants