Fix failing PHPUnit tests#7419
Conversation
|
Plugin builds for 3be7426 are ready 🛎️!
|
f6e64cc to
4b0c932
Compare
|
@westonruter While updating the
To avoid this error we will need to setup PHPUnit v9.3 here instead of letting it decide by the composer with |
In other words, it requires PHP 8.1 as a minimum? SGTM regardless. |
7d3fc3f to
721e15a
Compare
721e15a to
8ebe3d8
Compare
2752ecc to
6de964f
Compare
Codecov Report
@@ Coverage Diff @@
## develop #7419 +/- ##
==============================================
+ Coverage 64.76% 76.83% +12.07%
- Complexity 0 6864 +6864
==============================================
Files 67 281 +214
Lines 1189 27232 +26043
==============================================
+ Hits 770 20925 +20155
- Misses 419 6307 +5888
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
@westonruter This PR need to be merged before proceeding to any other PR that runs the PHPUnit tests workflow. |
| elif [[ $PHP_VERSION == "7.3" || $PHP_VERSION == "7.4" || $PHP_VERSION == "8.0" ]]; then | ||
| echo "Installing PHPUnit 9.3" | ||
| composer require --dev --ignore-platform-reqs phpunit/phpunit:"=9.3" --with-dependencies | ||
| elif [[ $WP_VERSION == "latest" || $WP_VERSION == "trunk" || $PHP_VERSION == "8.1" || $PHP_VERSION == "8.2" ]]; then |
There was a problem hiding this comment.
What about when PHP 8.3 comes out?
There was a problem hiding this comment.
I guess this will depend on us updating the matrix, so nevermind.
| elif [[ $WP_VERSION == "latest" || $WP_VERSION == "trunk" || $PHP_VERSION == "7.4" ]]; then | ||
| elif [[ $PHP_VERSION == "7.3" || $PHP_VERSION == "7.4" || $PHP_VERSION == "8.0" ]]; then | ||
| echo "Installing PHPUnit 9.3" | ||
| composer require --dev --ignore-platform-reqs phpunit/phpunit:"=9.3" --with-dependencies |
There was a problem hiding this comment.
Should this rather be:
| composer require --dev --ignore-platform-reqs phpunit/phpunit:"=9.3" --with-dependencies | |
| composer require --dev --ignore-platform-reqs phpunit/phpunit:"=9.3.*" --with-dependencies |
As this would account for bug fixes for that branch?
There was a problem hiding this comment.
Nice catch. It should rather be composer require --dev --ignore-platform-reqs phpunit/phpunit:"9.3.*" --with-dependencies as "=9.3.*" is an invalid version string.
Summary
Checklist