Fix local-env issue of missing xfs user#7813
Merged
Merged
Conversation
Contributor
|
Plugin builds for 14bfb80 are ready 🛎️!
ChecksumsWarning These builds are for testing purposes only and should not be used in production. |
westonruter
reviewed
Jun 5, 2024
Comment on lines
-12
to
-17
| # Check whether Node and NVM are installed | ||
| . "$(dirname "$0")/install-node-nvm.sh" | ||
|
|
||
| # Check whether Composer installed | ||
| . "$(dirname "$0")/install-composer.sh" | ||
|
|
Collaborator
Author
There was a problem hiding this comment.
No, the CI runners already have these tools pre-installed, and we configure NodeJS and Composer in the CI.
For local development, I doubt if this is being used given we already have wp-env setup.
westonruter
approved these changes
Jun 5, 2024
westonruter
left a comment
Member
There was a problem hiding this comment.
It's over my head, but LGTM!
Collaborator
Author
|
E2E tests are running now - https://github.com/ampproject/amp-wp/actions/runs/9391104052/job/25862514993. I'll fix the failing tests in a different PR after merging dependabot PRs. |
Collaborator
Author
|
E2E tests are running as expected in local env. QA Passed ✅. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
As it can be seen in the latest CI runs - https://github.com/ampproject/amp-wp/actions/runs/9389955987/job/25858689875, the
xfsuser is no longer available in the container powered by alpine Linux, and resulting in error like:This PR adds a custom Docker image which extends
wordpressimage and installs the wp-cli binary in the image itself.Checklist