Update the "non-javac-compilers" guide and add an integration test.#937
Merged
desruisseaux merged 2 commits intoapache:masterfrom Jun 26, 2025
Merged
Update the "non-javac-compilers" guide and add an integration test.#937desruisseaux merged 2 commits intoapache:masterfrom
desruisseaux merged 2 commits intoapache:masterfrom
Conversation
Contributor
|
Hi, will have a look in the next days or next weekend. Modt prob during the next days, when at an unconference. |
Bukama
requested changes
Jun 23, 2025
Contributor
Bukama
left a comment
There was a problem hiding this comment.
Overall good, only small suggestions/questions
| <configuration> | ||
| <compilerId>eclipse</compilerId> | ||
| <compilerId>ecj</compilerId> | ||
| <!-- TODO: remove source and target after we identified where Maven inherits those values. --> |
Contributor
There was a problem hiding this comment.
Suggest to create an issue for this, so it's more visible
Contributor
Author
There was a problem hiding this comment.
Yes, the problem is that I have been unable to identify from where Maven inherits those values (maven-core? maven-model-builder? somewhere else?) NetBeans "effective" POM view does not show them.
Contributor
Author
|
Thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #904.