Module descriptor not found when using forked compiler#983
Merged
desruisseaux merged 4 commits intoapache:masterfrom Oct 14, 2025
Merged
Module descriptor not found when using forked compiler#983desruisseaux merged 4 commits intoapache:masterfrom
desruisseaux merged 4 commits intoapache:masterfrom
Conversation
* More helpful exception when the workaround for the `--patch-module` option didn't work. * Some safety against null values in the `basedir` and `mojoStatusPath` fields of the MOJO. While those fields should never be null, it happens sometime when testing snapshot versions of Maven core.
Includes the case of toolchains, which are implicitly forked processes.
…o write debug files.
…rocessor to run. This commit takes in account the fact that `-proc:full` was the default before Java 23.
slawekjaranowski
approved these changes
Oct 14, 2025
|
@desruisseaux Please assign appropriate label to PR according to the type of change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes #966, which has been reported when using toolchains (the actual issue was with forked compiler rather than toolchains).
Since this pull request touches forked compilation, it opportunistically harmonizes the behaviour of forked and non-forked compilations regarding when to generate the
target/javac.argsdebug file(s). The harmonized behaviour is to generate these files when the compilation fails, or when the--verboseflag was given to Maven.The pull request also tries to be a little bit more specific in the message of exceptions thrown when the compiler does not accept a
--patch-moduleargument. This was a side-effect of the investigation on #966.