Merged
Conversation
…ed after 236fc26. Remove also `<release>17</release>` (because already inherited from the parent pom.xml) except when testing this option is the purpose of the integration test.
… anyway. Remove some `invoker.goals` when the `clean test-compile` default is suitable. Replace some `install` goals by the `verify` goal.
…is dot. Before this commit, we had two dots at the end of summary sentences in the generated Javadoc.
slawekjaranowski
approved these changes
Oct 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleanup in integration tests and in Javadoc. This pull requests does not change the main code.
<source/>and<target/>elements in thepom.xmlfiles of integration tests. These elements are no longer needed after 236fc26.<release>17</release>elements because they are inherited from the parentpom.xml. These elements are kept only when testing releases is the purpose of the integration test.invoker.java.version = 9+because the build requires Java 17 anyway.invoker.goalswhen theclean test-compiledefault is suitable.installgoals by theverifygoal in integration tests for avoiding to pollute the local repository.{@return …}because Javadoc already adds this dot.