gltrim: retain objects in the last frame that were created in earlier frames #807
Merged
jrfonseca merged 1 commit intoJun 28, 2022
Merged
Conversation
…arlier frames In order to be able to loop the last frame we must not destroy objects that are used in the last frame but not created there. For simplicity only check whether the object was created in the last frame, and not emit the delete code if it was not. Signed-off-by: Gert Wollny <gert.wollny@collabora.com>
babff26 to
cb39c17
Compare
Member
|
Looks reasonable to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to be able to loop the last frame we must not destroy objects
that are used in the last frame but not created there. For simplicity
only check whether the object was created in the last frame, and not
emit the delete code if it was not.
Remark:
This doesn't cover all cases where looping the last frame will fail, e.g. buffer mappings or context creation and destruction may also lead to crashes.