Re-enable and fix GL window system cleanup#961
Merged
Conversation
This reverts commit f9e11f9. I expect that XCloseDisplay is just fine with Mesa as of some point in the last 13 years. Regardless, if there's a problem with either GLX or EGL then we'd want to disable cleanup in the specific WS backend, not the frontend. With this, glws::cleanupX() gets called again, destroying our contexts and screen in Mesa, which means that utrace events get properly collected and flushed so that we can do performance analysis of apitrace replays.
eglTerminate() doesn't free a context until it's also not current. With this, our contexts and screen get destroyed in Mesa which means that utrace events get properly collected and flushed so that we can do performance analysis of apitrace replays.
Member
|
Makes sense. Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have a number of apitraces that we'd like to use for driver performance work with perfetto or MESA_GPU_TRACES=print_*, but we can't because a lack of cleanup of the window system means that the output gets arbitrarily truncated.
I've now confirmed that my screen gets destroyed on an EGL and a GLX trace from traces-db, with and without waffle. TBD: d3d.