Extract a method for locating Bazel#635
Merged
fweikert merged 1 commit intobazelbuild:masterfrom Dec 2, 2024
Merged
Conversation
9c88d59 to
ba94dbc
Compare
Contributor
Author
|
Running the failing |
Contributor
You maybe just unlucky, this test is running close to 5 min default limit. Also noticed this issue locally and created #637 to fix it. |
`bazelisk` can be thought of as two separate pieces. The first of these is a mechanism for locating a particular `bazel` version, possibly downloading it from the Web, or using a local install. The second piece is the additional functionality for flag flipping and finding out where problems have occurred within commits to the project. This PR extracts the location of the `bazel` binary into its own method which can be used by other tooling that also needs to locate the binary.
ba94dbc to
36ded79
Compare
Contributor
Author
|
@hauserx, I've rebased on |
fweikert
approved these changes
Dec 2, 2024
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bazeliskcan be thought of as two separate pieces. The first of these is a mechanism for locating a particularbazelversion, possibly downloading it from the Web, or using a local install. The second piece is the additional functionality for flag flipping and finding out where problems have occurred within commits to the project.This PR extracts the location of the
bazelbinary into its own method which can be used by other tooling that also needs to locate the binary.