Use legacy apparent names for rules_go and gazelle#649
Merged
meteorcloudy merged 1 commit intobazelbuild:masterfrom Jan 7, 2025
Merged
Use legacy apparent names for rules_go and gazelle#649meteorcloudy merged 1 commit intobazelbuild:masterfrom
meteorcloudy merged 1 commit intobazelbuild:masterfrom
Conversation
Contributor
Author
meteorcloudy
approved these changes
Jan 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When bazelisk is brought in as a Go dependency via gazelle's
go_depsextension, it uses the repo mapping of thegazellemodule to resolve loads. Sincegazelleuses the legacy apparent namesbazel_gazelleandio_bazel_rules_gofor thegazelleandrules_gomodules, the same is required for any Bazel module that is also a Go module (until gazelle gains the ability to fix load labels).This regressed in 4448ad1.