make release candidate versions handling on BAZELISK_BASE_URL consistent with github url#722
Merged
fweikert merged 1 commit intobazelbuild:masterfrom Oct 9, 2025
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
9a13a17 to
a0ec9fe
Compare
Make this more consistent with the github.com release urls, for simpler mirrors. This is a non-backwards compatible change, so we may want to introduce a new ENV var to prevent breakages with existing setups that are working.
a0ec9fe to
488f57f
Compare
Contributor
Author
|
Addressed CLA |
fweikert
approved these changes
Oct 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The README states:
<VERSION>typically includes the release candidate, e.g.8.4.1rc2. But currently, it only appends8.4.1without therc2.This PR fixes this to
8.4.1rc2. It also make this more consistent with the github.com release urls, to make mirroring the github release urls simpler. This is a non-backwards compatible change, so we may want to introduce a new ENV var to prevent breakages with existing setups that are working.If there's interest in this, I can leave add an environment variable to toggle it on, and leave it for V2 to turn it on by default.