Report a proper exit code when Bazel is terminated by signal and use exec on Unix in the case of bazelisk run#757
Conversation
…d process in the case of `run` command Fixes bazelbuild#512 and bazelbuild#556
|
@fweikert, could you please take a look at it? |
|
@valco1994 why only exec when we find a This seems especially confusing if I'm reading correctly and this will exec if you do like |
|
@aaron-skydio, I missed your pull request, and found it only when my pull request was already merged. So, I didn't consider making Considering the motivation, I wanted to fix issues reported by users - #512 and #556 - and in both cases, problematic scenarios were related to I have nothing against using |
|
Yeah, I think the best (and easiest) way to be a transparent wrapper in general is with |
|
Your reasoning is really well-founded, and an example with But I'm not a maintainer of this project, just a regular contributor. @fweikert, what do you think about the idea of @aaron-skydio? |
It fixes issues #512 and #556