Skip to content

feat: drop support for legacy module namespaces #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
acutmore merged 3 commits into from
Feb 12, 2025
Merged

feat: drop support for legacy module namespaces #39

acutmore merged 3 commits into from
Feb 12, 2025

Conversation

@acutmore
Copy link
Collaborator

@acutmore acutmore commented Feb 10, 2025 •
edited
Loading

Context

microsoft/TypeScript#51825
nodejs/amaro#168

Description

This PR is a breaking change.
Continuing on from #32 but instead of allowing more ModuleDeclaration AST nodes, this PR removes support for erasing namespace declarations that use the deprecated module keyword.

Still erased (no error emitted)

declare namespace N1 {}
namespace N2 {}
declare global {}
declare module "./path" {}

No longer erased (triggers onError callback)

declare module M1 {}
module M2 {}

@acutmore
feat: drop support for legacy module namespaces
6149a2c 
nodejs/amaro#168

Signed-off-by: Ashley Claymore <aclaymore@bloomberg.net>
@acutmore acutmore requested a review from robpalme February 10, 2025 16:04
robpalme
robpalme reviewed Feb 10, 2025
View reviewed changes
Copy link
Contributor

@robpalme robpalme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a doc issue

@acutmore @robpalme
Update docs/unsupported_syntax.md
a494f08 
Co-authored-by: Rob Palmer <rob.palmer2@gmail.com>
Signed-off-by: Ashley Claymore <aclaymore@bloomberg.net>
@acutmore acutmore marked this pull request as ready for review February 11, 2025 17:02
@acutmore acutmore merged commit bd999bc into main Feb 12, 2025
2 checks passed
@acutmore acutmore deleted the drop-legacy-modules branch February 12, 2025 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@robpalme robpalme robpalme approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@acutmore @robpalme