Skip to content

[35.0.0] x64: Fix a missing lowering rule for select_spectre_guard#11248

Merged
alexcrichton merged 1 commit intobytecodealliance:release-35.0.0from
alexcrichton:back35
Jul 22, 2025
Merged

[35.0.0] x64: Fix a missing lowering rule for select_spectre_guard#11248
alexcrichton merged 1 commit intobytecodealliance:release-35.0.0from
alexcrichton:back35

Conversation

@alexcrichton
Copy link
Member

Backport of #11242

…liance#11242)

This commit fixes an accidental regression from bytecodealliance#11097 where a
`select_spectre_guard` with a boolean condition that and'd two CCs
together would fail to lower and cause a panic during lowering. This was
reachable when explicit bounds checks are enabled from wasm, for
example. The fix here is to handle the `And` condition in the same way
that lowering `select` does which is to model that as it flows into the
select helper.
@alexcrichton alexcrichton requested a review from a team as a code owner July 15, 2025 17:53
@alexcrichton alexcrichton requested review from cfallin and removed request for a team July 15, 2025 17:53
@github-actions github-actions bot added cranelift Issues related to the Cranelift code generator cranelift:area:x64 Issues related to x64 codegen labels Jul 15, 2025
@alexcrichton alexcrichton requested review from a team as code owners July 22, 2025 14:48
@alexcrichton alexcrichton requested review from pchickey and removed request for a team July 22, 2025 14:48
@alexcrichton alexcrichton enabled auto-merge (squash) July 22, 2025 15:28
@alexcrichton alexcrichton merged commit 99325c5 into bytecodealliance:release-35.0.0 Jul 22, 2025
493 of 495 checks passed
@alexcrichton alexcrichton deleted the back35 branch July 22, 2025 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cranelift:area:x64 Issues related to x64 codegen cranelift Issues related to the Cranelift code generator

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants