fix(config): improve configuration merges #1285
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The library we were using does not provide a good way to handle exceptions et al. Even if it did, we probably need to handle this in a case-by-case basis, as the correct thing to do for each property is different. This removes the library, introducing a manual merge process, and starts adding tests to verify it all. Ideally, we should also document what happens for each option. closes #932 closes #241 Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
acd2af1 to
96a8317
Compare
andreynering
approved these changes
Nov 5, 2025
Member
|
@caarlos0 can we get this rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The library we were using does not provide a good way to handle exceptions et al.
Even if it did, we probably need to handle this in a case-by-case basis, as the correct thing to do for each property is different.
This removes the library, introducing a manual merge process, and starts adding tests to verify it all.
Ideally, we should also document what happens for each option.
closes #932
closes #241