Support simple views in domain association#5106
Merged
Merged
Conversation
Also give a useful error message for non-simple views.
seldridge
approved these changes
Dec 3, 2025
seldridge
left a comment
Member
There was a problem hiding this comment.
LGTM
Can you also include a test that this works with FlatIO? (I think it should work now?)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assuming
associatesupports aggregates, then we should also support non 1-1 views, but it's more complicated to implement so I figured I'd get this out while I ponder how best to handle that. The solution also has implications for how other internal APIs should handle views--I really didn't do a great job on the internal utilities so I'm thinking about that.Contributor Checklist
docs/src?Type of Improvement
Desired Merge Strategy
Release Notes
Also give a useful error message for non-simple views.
Reviewer Checklist (only modified by reviewer)
3.6.x,5.x, or6.xdepending on impact, API modification or big change:7.0)?Enable auto-merge (squash)and clean up the commit message.Create a merge commit.