Add source locators to more module kinds#5116
Merged
Merged
Conversation
Add missing source locators to: - BlackBox - ExtModule - IntrinsicModule Previously, this information would be just dropped which resulted in sub-par error messages for errors generated by `firtool`. Concretely, this helps with error messages generated by the `InferDomains` pass where a frequent problem is missing domain information on external modules. Fixes #5115. Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
jackkoenig
approved these changes
Dec 11, 2025
jackkoenig
left a comment
Contributor
There was a problem hiding this comment.
Thanks for fixing this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add missing source locators to:
Previously, this information would be just dropped which resulted in
sub-par error messages for errors generated by
firtool. Concretely,this helps with error messages generated by the
InferDomainspass wherea frequent problem is missing domain information on external modules.
Fixes #5115.
Signed-off-by: Schuyler Eldridge schuyler.eldridge@sifive.com
Release Notes
Add source locators to BlackBox, ExtModule, and IntrinsicModule.