[core] Add associate method for Seq of ports#5122
Merged
Merged
Conversation
Add an additional `associate` method that can be used for multiple ports. I'm finding myself frequently writing the following and this avoids it: ``` scala Seq(x, y, z).foreach(associate(_, A)) ``` Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
jackkoenig
approved these changes
Dec 15, 2025
Member
Author
|
Yeah... I was thinking something similar. I do like your sketch of Honestly, any varargs may just be weird here as I can see wanting either. Maybe just switching to a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an additional
associatemethod that can be used for multiple ports.I'm finding myself frequently writing the following and this avoids it:
Release Notes
Add additional domain
associatemethod that accepts a sequence of ports.