Skip to content

Add noModulePrefix#5147

Merged
jackkoenig merged 5 commits into
chipsalliance:mainfrom
trmckay:tmckay/no-module-prefix
Jan 14, 2026
Merged

Add noModulePrefix#5147
jackkoenig merged 5 commits into
chipsalliance:mainfrom
trmckay:tmckay/no-module-prefix

Conversation

@trmckay

@trmckay trmckay commented Jan 13, 2026

Copy link
Copy Markdown
Contributor

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Feature (or new API)

Desired Merge Strategy

  • Squash: The PR will be squashed and merged (choose this if you have no preference).

Release Notes

  • Add noModulePrefix to generate module definitions with no prefixing applied.

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash) and clean up the commit message.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

@trmckay trmckay requested a review from jackkoenig January 13, 2026 22:52
@trmckay trmckay changed the title Add Module.noModulePrefix API Add Module.noModulePrefix Jan 13, 2026
@trmckay trmckay added the Feature New feature, will be included in release notes label Jan 13, 2026

@jackkoenig jackkoenig left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, a couple of minor suggestions.

Comment thread core/src/main/scala/chisel3/Module.scala Outdated
Comment thread src/test/scala-2/chiselTests/ModulePrefixSpec.scala
@jackkoenig jackkoenig changed the title Add Module.noModulePrefix Add noModulePrefix Jan 14, 2026
@jackkoenig

Copy link
Copy Markdown
Contributor

I changed the title because this isn't really Module.noModulePrefix as noModulePrefix is not inside of object Module, it's just in the same file.

@jackkoenig jackkoenig merged commit b301e0f into chipsalliance:main Jan 14, 2026
25 checks passed
@trmckay

trmckay commented Jan 14, 2026

Copy link
Copy Markdown
Contributor Author

I changed the title because this isn't really Module.noModulePrefix as noModulePrefix is not inside of object Module, it's just in the same file.

Ah thanks for the correction 🫡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature New feature, will be included in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants