Add FlattenInstanceAllowDedup#5162
Merged
Merged
Conversation
b82c215 to
2570ca3
Compare
seldridge
approved these changes
Jan 20, 2026
Member
There was a problem hiding this comment.
I'm surprised we don't have a FlattenSpec already!
Comment on lines
+51
to
+61
| .fileCheck("--implicit-check-not=module")( | ||
| """|CHECK: module Leaf | ||
| |CHECK: endmodule | ||
| |CHECK: module Middle | ||
| |CHECK: endmodule | ||
| |CHECK: module Parent | ||
| |CHECK: endmodule | ||
| |CHECK: module Parent_1 | ||
| |CHECK: endmodule | ||
| |CHECK: module Top | ||
| |CHECK: endmodule |
Member
There was a problem hiding this comment.
This might work:
Suggested change
| .fileCheck("--implicit-check-not=module")( | |
| """|CHECK: module Leaf | |
| |CHECK: endmodule | |
| |CHECK: module Middle | |
| |CHECK: endmodule | |
| |CHECK: module Parent | |
| |CHECK: endmodule | |
| |CHECK: module Parent_1 | |
| |CHECK: endmodule | |
| |CHECK: module Top | |
| |CHECK: endmodule | |
| .fileCheck("--implicit-check-not=' module '")( | |
| """|CHECK: module Leaf | |
| |CHECK: module Middle | |
| |CHECK: module Parent | |
| |CHECK: module Parent_1 | |
| |CHECK: module Top |
Ditto below.
Contributor
Author
There was a problem hiding this comment.
Good tip, I was reaching for something like this, will give it a go.
Contributor
Author
There was a problem hiding this comment.
Sadly that doesn't work (it doesn't catch the bugs I'm trying to catch) so I'll stick with this for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We ought to make the normal inline and flattening APIs allow dedup as the reasons they blocked dedup are now better handled by prefixing + dedup groups, but within the current API this is still useful.
Contributor Checklist
docs/src?Type of Improvement
Desired Merge Strategy
Release Notes
Reviewer Checklist (only modified by reviewer)
3.6.x,5.x, or6.xdepending on impact, API modification or big change:7.0)?Enable auto-merge (squash)and clean up the commit message.Create a merge commit.