Add domain instantiation operation#5239
Merged
Merged
Conversation
2ad9372 to
2e6310b
Compare
bd7c41c to
a72f912
Compare
2e6310b to
7c74e54
Compare
4ede800 to
10e0e94
Compare
0a2daa7 to
a510324
Compare
10e0e94 to
4988152
Compare
a510324 to
9be0036
Compare
960693f to
b7d61e3
Compare
seldridge
commented
Mar 20, 2026
| } | ||
|
|
||
| protected[properties] val tpe: PropertyType[_] | ||
| protected[chisel3] val tpe: PropertyType[_] |
Member
Author
There was a problem hiding this comment.
This is exposed to enable checking that the property types passed to the domain create API are correct.
jackkoenig
reviewed
Mar 20, 2026
jackkoenig
left a comment
Contributor
There was a problem hiding this comment.
A few thoughts, not going to sandbag on my long-term vision but there might be some little things we can do in the meantime.
1259c2e to
275f858
Compare
95d3a15 to
503f39b
Compare
jackkoenig
approved these changes
Mar 20, 2026
Add a new domain instantiation operation. This maps to an existing
CIRCT `DomainCreateOp` with undocumented FIRRTL syntax:
domain foo of ClockDomain(String("Foo"), String("Bar"))
Domain instantiation occurs in situations where a new domain is created
which may either be wholly novel (e.g., a clock generator) or derived from
an existing domain (e.g., a clock divider).
AI-assisted-by: Augment (Claude Sonnet 4.5)
Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
275f858 to
f25d1d1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new domain instantiation operation. This maps to an existing
CIRCT
DomainCreateOpwith undocumented FIRRTL syntax:Domain instantiation occurs in situations where a new domain is created
which may either be wholly novel (e.g., a clock generator) or derived from
an existing domain (e.g., a clock divider).
AI-assisted-by: Augment (Claude Sonnet 4.5)
Release Notes
Add domain instantiation API. This is useful for describing modules which
create wholly new or domains derived from other domains.