Skip to content

[Scala3] Add Instantiate API#5278

Merged
adkian-sifive merged 8 commits into
mainfrom
adkian-sifive/scala3-instantiate
May 6, 2026
Merged

[Scala3] Add Instantiate API#5278
adkian-sifive merged 8 commits into
mainfrom
adkian-sifive/scala3-instantiate

Conversation

@adkian-sifive

@adkian-sifive adkian-sifive commented Apr 22, 2026

Copy link
Copy Markdown
Member

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Feature (or new API)

Desired Merge Strategy

  • Squash: The PR will be squashed and merged (choose this if you have no preference).

Release Notes

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash) and clean up the commit message.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

@adkian-sifive adkian-sifive added the Scala 3 Changes related to upgrading to Scala 3 label Apr 22, 2026
@adkian-sifive adkian-sifive changed the base branch from main to adkian-sifive/scala3-di April 22, 2026 00:01
Comment thread core/src/main/scala-3/chisel3/experimental/hierarchy/InstantiateIntf.scala Outdated
Comment thread core/src/main/scala-3/chisel3/experimental/hierarchy/InstantiateIntf.scala Outdated
Comment thread core/src/main/scala-3/chisel3/experimental/hierarchy/InstantiateIntf.scala Outdated
Comment thread core/src/main/scala-3/chisel3/experimental/hierarchy/InstantiateIntf.scala Outdated
Comment thread core/src/main/scala-3/chisel3/experimental/hierarchy/InstantiateIntf.scala Outdated
Base automatically changed from adkian-sifive/scala3-di to main May 5, 2026 01:33
@adkian-sifive adkian-sifive force-pushed the adkian-sifive/scala3-instantiate branch from 99b0784 to 26fc1c9 Compare May 5, 2026 01:55
Refactor helpers for clarity
Remove implicit special handling
Update SourceInfo handling

@jackkoenig jackkoenig left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 1 comment nit

Comment thread core/src/main/scala-3/chisel3/experimental/hierarchy/InstantiateIntf.scala Outdated
@adkian-sifive adkian-sifive enabled auto-merge (squash) May 6, 2026 18:35
@adkian-sifive adkian-sifive merged commit cb6d081 into main May 6, 2026
28 checks passed
@adkian-sifive adkian-sifive deleted the adkian-sifive/scala3-instantiate branch May 6, 2026 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scala 3 Changes related to upgrading to Scala 3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants