Skip to content

[Scala3] Add DataView macros and move tests#5334

Merged
adkian-sifive merged 4 commits into
mainfrom
adkian-sifive/scala3-dataview-macros
May 19, 2026
Merged

[Scala3] Add DataView macros and move tests#5334
adkian-sifive merged 4 commits into
mainfrom
adkian-sifive/scala3-dataview-macros

Conversation

@adkian-sifive

Copy link
Copy Markdown
Member

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Feature (or new API)
  • API modification
  • API deprecation
  • Backend code generation
  • Performance improvement
  • Bugfix
  • Documentation or website-related
  • Dependency update
  • Internal or build-related (includes code refactoring/cleanup)

Desired Merge Strategy

  • Squash: The PR will be squashed and merged (choose this if you have no preference).
  • Rebase: You will rebase the PR onto master and it will be merged with a merge commit.

Release Notes

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash) and clean up the commit message.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

@adkian-sifive adkian-sifive added the Scala 3 Changes related to upgrading to Scala 3 label May 13, 2026
@adkian-sifive adkian-sifive mentioned this pull request May 14, 2026
14 tasks

@jackkoenig jackkoenig left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit but otherwise LGTM

@adkian-sifive adkian-sifive force-pushed the adkian-sifive/scala3-dataview-macros branch from 3df8857 to 0ae4a80 Compare May 19, 2026 01:47
@adkian-sifive adkian-sifive enabled auto-merge (squash) May 19, 2026 01:48
@adkian-sifive adkian-sifive disabled auto-merge May 19, 2026 02:10
@adkian-sifive adkian-sifive force-pushed the adkian-sifive/scala3-dataview-macros branch from 0f42a38 to 91e195c Compare May 19, 2026 18:30
@adkian-sifive adkian-sifive enabled auto-merge (squash) May 19, 2026 18:30
@adkian-sifive adkian-sifive merged commit e6c9801 into main May 19, 2026
28 checks passed
@adkian-sifive adkian-sifive deleted the adkian-sifive/scala3-dataview-macros branch May 19, 2026 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scala 3 Changes related to upgrading to Scala 3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants