Scala 2: skip mixing in IsInstantiable if mixed in already#5384
Merged
adkian-sifive merged 5 commits intoMay 30, 2026
Conversation
jackkoenig
reviewed
May 28, 2026
jackkoenig
left a comment
Contributor
There was a problem hiding this comment.
The @INSTANTIABLE annotation is deprecated in Chisel 7 and won't be supported in Chisel 8 and Scala 3. This change will help transition away from it by allowing user code to cross compile when it has both the annotation and an explicit IsInstantiable mixin
The annotation itself isn't deprecated, but using it on non-Modules is. We'll probably go ahead and deprecated it in Scala 3 though.
PR looks good other than the one comment
jackkoenig
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
@instantiableannotation on non-Modules is deprecated in Chisel 7 and won't be supported in Chisel 8 and Scala 3. This change will help transition away from it by allowing user code to cross compile when it has both the annotation and an explicitIsInstantiablemixinRelease Notes
User code can now have both the
@instantiableannotation and an explicitIsInstantiablemixin in Scala 2 and Scala 3Development notes