Skip to content

[Scala3] Move tests to src/test/scala/#5388

Merged
adkian-sifive merged 6 commits into
mainfrom
adkian-sifive/scala3-move-tests
May 29, 2026
Merged

[Scala3] Move tests to src/test/scala/#5388
adkian-sifive merged 6 commits into
mainfrom
adkian-sifive/scala3-move-tests

Conversation

@adkian-sifive

Copy link
Copy Markdown
Member

Summary

Move tests with minor changes to run with Scala 3 to cross run

Release Notes

Move tests with minor changes to run with Scala 3 to cross run

Development notes

  • AI tool(s) used: Claude Code + Claude Opus 4.7
  • Merge strategy (defaults to squash): I've tried to keep the commits clean, we should rebase them

@adkian-sifive adkian-sifive added API Modification Scala 3 Changes related to upgrading to Scala 3 and removed API Modification labels May 28, 2026
@adkian-sifive adkian-sifive force-pushed the adkian-sifive/scala3-move-tests branch from 7a71e04 to 3e23ed7 Compare May 28, 2026 23:16
Comment on lines +129 to +130
class MkBundle { def mkBundle = new Bundle { val x = Vec(n, gen) } }
val bar = Output(Option(new MkBundle).get.mkBundle)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to do some archeology to convince myself that this matches the spirit of the test. I think it's fine

@adkian-sifive adkian-sifive merged commit 3827a6c into main May 29, 2026
28 checks passed
@adkian-sifive adkian-sifive deleted the adkian-sifive/scala3-move-tests branch May 29, 2026 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scala 3 Changes related to upgrading to Scala 3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants