dap: refactor how steps are evaluated in the program #3483
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2aa9ec9 to
28fad83
Compare
This change modifies how steps are evaluated in the program. Previously, the execution relied on looking for the digest we were going to stop at and evaluating the step right before that digest. This could result in some gaps where it erroneously didn't execute inputs for the current step as it skipped those digests. Now, the evaluation reads the inputs and executed those directly rather than relying on the evaluation of previous steps in the sequence. This should make the evaluation of inputs more accurate and allow us to have better breakpoints on things like the copy operation. Due to the change, it's also easier for us to include the different inputs in the file explorer. Signed-off-by: Jonathan A. Sternberg <jonathan.sternberg@docker.com>
28fad83 to
4345a8e
Compare
tonistiigi
reviewed
Oct 29, 2025
Member
tonistiigi
left a comment
There was a problem hiding this comment.
SGTM but as this is getting quite complicated I think we need to improve unit and integration test coverage in follow-up.
tonistiigi
approved these changes
Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change modifies how steps are evaluated in the program. Previously,
the execution relied on looking for the digest we were going to stop at
and evaluating the step right before that digest. This could result in
some gaps where it erroneously didn't execute inputs for the current
step as it skipped those digests.
Now, the evaluation reads the inputs and executed those directly rather
than relying on the evaluation of previous steps in the sequence. This
should make the evaluation of inputs more accurate and allow us to have
better breakpoints on things like the copy operation.
Due to the change, it's also easier for us to include the different
inputs in the file explorer.
Fixes #3469.