Conversation
This reverts commit 720da7d.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pinned VCPKG dependencies were working as of yesterday:
But within a day, they broke:
Not a big deal; maybe there were some package changes.
I updated our manifest's baseline to the latest:
However, this didn't help.
The root cause is due VCPKG's "minimum-version" policy conflicting with repository maintainers desire to keep the "maximally-fixed-repo" versions and drop the "least-fixed-repo" versions, for a given major.minor.bugfix series.
For example: vcpkg determined that libtool-2.4.6-9 is the least version that can satisfy the requirement, but the repo maintainers have rolled off libtool-2.4.6-9 and kept >= libtool-2.4.6-10:
We can see how it plays out here:
Why did our non-pinned builds work but the pinned builds failed?
Because this minimum-version policy is only applied when using versioned manifests.
.. within 24 hours, we've already been shown a real-world example of how quickly the pinned version tree gets in trouble and produced a configuration that's no longer available to download or build... and we were using the latest possible dependency versions available.
So for now, I'm reverting the VCPKG pinned approach. But keeping the Meson bracketing.
Because VCPKG cannot force repo hosts to keep the oldest, buggiest versions to satisfy VCPKG's minimum-version-policy, the only viable route is for them to offer bounded versions.