Skip to content

Filesystem fixes#2288

Merged
kcgen merged 3 commits intomainfrom
nn/fs
Feb 20, 2023
Merged

Filesystem fixes#2288
kcgen merged 3 commits intomainfrom
nn/fs

Conversation

@NicknineTheEagle
Copy link
Copy Markdown
Contributor

@NicknineTheEagle NicknineTheEagle commented Feb 19, 2023 •
edited
Loading

  • Fix floppy mount label not updating on rescan. Was broken by an optimization.
  • Return error in local FS on file write failure. Local FS currently returns success even on complete write failure.
  • Added a setting to config that allows user to allow/disallow r/w opens of write-protected files in local FS. This makes behavior added in Permit the use of protected game data files #143 optional - while it's more user-friendly it's also inaccurate to real DOS so it should be possible to turn it off.

@NicknineTheEagle NicknineTheEagle self-assigned this Feb 19, 2023
kcgen
kcgen reviewed Feb 19, 2023
View reviewed changes
Comment thread src/dos/drive_cache.cpp
kcgen
kcgen reviewed Feb 19, 2023
View reviewed changes
Comment thread src/dos/drive_local.cpp
kcgen
kcgen reviewed Feb 19, 2023
View reviewed changes
Comment thread src/dos/drive_local.cpp Outdated
kcgen
kcgen reviewed Feb 19, 2023
View reviewed changes
Comment thread src/dos/drive_local.cpp Outdated
kcgen
kcgen reviewed Feb 19, 2023
View reviewed changes
Comment thread src/dosbox.cpp Outdated
@kcgen kcgen added regression We broke something 😊 enhancement New feature or enhancement of existing features labels Feb 19, 2023
kcgen
kcgen reviewed Feb 19, 2023
View reviewed changes
Comment thread src/dos/program_mount.cpp Outdated
@NicknineTheEagle NicknineTheEagle force-pushed the nn/fs branch 2 times, most recently from 13e3bbc to 64a2451 Compare February 20, 2023 13:25
@NicknineTheEagle NicknineTheEagle force-pushed the nn/fs branch 3 times, most recently from 85b5304 to 23ab30c Compare February 20, 2023 15:33
kcgen
kcgen reviewed Feb 20, 2023
View reviewed changes
Comment thread include/drives.h Outdated
@kcgen
Copy link
Copy Markdown
Member

kcgen commented Feb 20, 2023

Thanks for yet another round of nice fixes, @NicknineTheEagle !

@kcgen kcgen merged commit 0121789 into main Feb 20, 2023
@delete-merged-branch delete-merged-branch Bot deleted the nn/fs branch February 20, 2023 20:19
@Grounded0 Grounded0 mentioned this pull request Nov 17, 2023
Closed
4 tasks
@johnnovak johnnovak added the DOS Issues related to DOS integration or DOS commands label Dec 11, 2023
@weirddan455 weirddan455 mentioned this pull request Jun 20, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@johnnovak johnnovak johnnovak left review comments

@kcgen kcgen kcgen approved these changes

Assignees

@NicknineTheEagle NicknineTheEagle

Labels

DOS Issues related to DOS integration or DOS commands enhancement New feature or enhancement of existing features regression We broke something 😊

Projects

No open projects
0.81 Project
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@NicknineTheEagle @kcgen @johnnovak