Conversation
Excellent, @Kappa971. If you're using this BAT file successfully, could you make another PR that adds it? |
There is some discussion here https://www.computerhope.com/unix/dos2unix.htm#conversion about using dos2unix combined with UTF-8 files, maybe we need to make some adjustments to the Another thought - maybe the
It looks like those extra symbols to the if (translit != NULL && *translit) {
UParseError parse;
UnicodeString str(translit), pestr;
/* Create from rules or by ID as needed. */
parse.line = -1;
if (uprv_strchr(translit, ':') || uprv_strchr(translit, '>') || uprv_strchr(translit, '<') || uprv_strchr(translit, '>')) {
t = Transliterator::createFromRules(UNICODE_STRING_SIMPLE("Uconv"), str, UTRANS_FORWARD, parse, err);
} else {
t = Transliterator::createInstance(UnicodeString(translit, -1, US_INV), UTRANS_FORWARD, err);
}So it could be that the windows implementation of @FeralChild64 - do you know more about this? I think we want to let more people on Windows help with translation, so overall this is a great addition. During any merge step, we will see all the diff'ed lines if MSYS2 If there's anything strange, it will jump out in the PR diffs. |
It's probably enough for the respective translators to replace those codes with the new color tags, right?
The funny thing is that this "Windows implementation" of uconv is taken from MSYS2 (I don't know where else to get it). On MSYS2 environment, the EDIT |
|
@kcgen Sorry, I have no idea why Windows version behaves differently. |
I think we should be OK. These tools are released by the ICU project (and they're on version 72!), I suspect our relatively simple (only UTF-8) cases should be handled without problems. Worst-case: if we see any damaged formatting in future PRs, then someone can try the Linux/macOS script and compare the results. If there are fatal flaws, then we can drop the batch file and then recommend only using non-Windows platforms for the conversion. But hopefully this is all just unnecessary planning :-) |


I created this batch file Encode.zip (for Windows) which goes in the
contrib\resources\translationsdirectory, based on theencode.shLinux script.I'm no expert, I think it works but I'm not sure about the
uconvcommand.