core_dyn_x86: Initialise rettype to avoid compiler warning#2365
Merged
kcgen merged 1 commit intodosbox-staging:mainfrom Mar 25, 2023
Merged
core_dyn_x86: Initialise rettype to avoid compiler warning#2365kcgen merged 1 commit intodosbox-staging:mainfrom
kcgen merged 1 commit intodosbox-staging:mainfrom
Conversation
gcc 13 warns when uninitialised data could be read, and picks up the
following in risc_x64.h:
```
In file included from ../src/cpu/core_dyn_x86.cpp:199:
../src/cpu/core_dyn_x86/risc_x64.h: In function ‘void gen_call_function(void*, const char*, ...)’:
../src/cpu/core_dyn_x86/risc_x64.h:1127:25: warning: ‘rettype’ may be used uninitialized [-Wmaybe-uninitialized]
1127 | switch (rettype) {
| ^~~~~~
../src/cpu/core_dyn_x86/risc_x64.h:1075:14: note: ‘rettype’ was declared here
1075 | char rettype;
| ^~~~~~~
```
While this isn't actually a problem (rettype is only read if dynret is
non-NULL, and dynret is only set when rettype is), it's probably worth
initialising rettype just to keep the build warning-free.
Member
|
Nice little cleanup; thanks for adding it @sulix ! |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tl;dr: A quick warning fix with gcc 13 I found while looking at the OPL stuff.
gcc 13 warns when uninitialised data could be read, and picks up the following in risc_x64.h:
While this isn't actually a problem (rettype is only read if dynret is non-NULL, and dynret is only set when rettype is), it's probably worth initialising rettype just to keep the build warning-free.