Skip to content

Auto enable shell variable expansion for DOS >=7#2378

Merged
kcgen merged 1 commit intomainfrom
rdr/expand-shell-variable-1
Apr 4, 2023
Merged

Auto enable shell variable expansion for DOS >=7#2378
kcgen merged 1 commit intomainfrom
rdr/expand-shell-variable-1

Conversation

@rderooy
Copy link
Copy Markdown
Collaborator

@rderooy rderooy commented Apr 4, 2023

Automatically enable shell variable expansion when DOS version is set to >= 7.0

closes #2279

Copy link
Copy Markdown
Member

@kcgen kcgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor suggestions - logic all looks good, @rderooy !

Comment thread src/dosbox.cpp Outdated
Comment thread src/shell/shell_misc.cpp Outdated
@rderooy rderooy force-pushed the rdr/expand-shell-variable-1 branch from 28f07d1 to 3a0c7b8 Compare April 4, 2023 20:25
Copy link
Copy Markdown
Member

@kcgen kcgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to have this shell-expansion now on auto-mode, matching the DOS version. Nice PR, @rderooy 🚀

@kcgen kcgen merged commit 7ddd178 into main Apr 4, 2023
@kcgen kcgen added the enhancement New feature or enhancement of existing features label Apr 4, 2023
@kcgen kcgen deleted the rdr/expand-shell-variable-1 branch April 8, 2023 01:45
@johnnovak johnnovak added the DOS Issues related to DOS integration or DOS commands label Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DOS Issues related to DOS integration or DOS commands enhancement New feature or enhancement of existing features

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

Echo environment variable does not work

3 participants