Skip to content

Add full file path printing for file related debugger commands#2472

Merged
dreamer merged 1 commit intodosbox-staging:mainfrom
LowLevelMahn:llm/debugger-log-full-path
May 14, 2023
Merged

Add full file path printing for file related debugger commands#2472
dreamer merged 1 commit intodosbox-staging:mainfrom
LowLevelMahn:llm/debugger-log-full-path

Conversation

@LowLevelMahn
Copy link
Copy Markdown
Contributor

@LowLevelMahn LowLevelMahn commented May 11, 2023 •
edited
Loading

its not always clear were the CPULOG or MEMDUMP, etc. files getting created - or better said what the current working directy is when started relativly from console, using batch file or from IDE
the full path makes it absolutely clear

dreamer
dreamer requested changes May 11, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@dreamer dreamer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a single request, and please amend the commit message to follow our required style.

Comment thread src/debug/debug.cpp Outdated
@LowLevelMahn
Copy link
Copy Markdown
Contributor Author

LowLevelMahn commented May 11, 2023

Just a single request, and please amend the commit message to follow our required style.

i did

git commit --amend and changed the text in both branches but can't see the change in this pull request

@dreamer dreamer changed the title adds full file path printing for file related debugger commands Add full file path printing for file related debugger commands May 12, 2023
dreamer
dreamer reviewed May 12, 2023
View reviewed changes
Comment thread src/debug/debug.cpp Outdated
@dreamer dreamer added the enhancement New feature or enhancement of existing features label May 12, 2023
@johnnovak
Copy link
Copy Markdown
Member

johnnovak commented May 12, 2023

Just a single request, and please amend the commit message to follow our required style.

i did

git commit --amend and changed the text in both branches but can't see the change in this pull request

You need to force push and you should see them.

@LowLevelMahn
Copy link
Copy Markdown
Contributor Author

LowLevelMahn commented May 13, 2023

Just a single request, and please amend the commit message to follow our required style.

i did
git commit --amend and changed the text in both branches but can't see the change in this pull request

You need to force push and you should see them.

i've done that but thought that the PR title will change automaticly - so i just forget to also change the PR title

@johnnovak
Copy link
Copy Markdown
Member

johnnovak commented May 13, 2023

Just a single request, and please amend the commit message to follow our required style.

i did
git commit --amend and changed the text in both branches but can't see the change in this pull request

You need to force push and you should see them.

i've done that but thought that the PR title will change automaticly - so i just forget to also change the PR title

Git gud, man! 😎

dreamer
dreamer approved these changes May 14, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@dreamer dreamer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect 😄. Thank you @LowLevelMahn!

@kcgen kcgen self-requested a review May 14, 2023 18:45
kcgen
kcgen approved these changes May 14, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@kcgen kcgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @LowLevelMahn

@dreamer dreamer merged commit 57b4b8f into dosbox-staging:main May 14, 2023
@LowLevelMahn LowLevelMahn deleted the llm/debugger-log-full-path branch May 18, 2023 06:41
@Grounded0 Grounded0 mentioned this pull request Nov 17, 2023
Closed
4 tasks
@johnnovak johnnovak added the DOS Issues related to DOS integration or DOS commands label Dec 11, 2023
@kcgen kcgen added the debugger Issues related to the debugger label Dec 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@johnnovak johnnovak johnnovak left review comments

@dreamer dreamer dreamer approved these changes

@kcgen kcgen kcgen approved these changes

Assignees

@LowLevelMahn LowLevelMahn

Labels

debugger Issues related to the debugger DOS Issues related to DOS integration or DOS commands enhancement New feature or enhancement of existing features

Projects

No open projects
0.81 Project
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@LowLevelMahn @johnnovak @dreamer @kcgen