Don't auto-disable OpenGL for debugger-enabled builds on Linux#2480
Merged
Don't auto-disable OpenGL for debugger-enabled builds on Linux#2480
Conversation
bb1cfcd to
2d4641e
Compare
Member
Author
|
Allowing OpenGL in debugger-enabled builds opened up more code paths (which in turn resulted in more warnings), so this PR had to squash those. @GranMinigun , I tried to be as minimal as possible to resude the rebase-pain for both your active sdlmain PRs. |
GranMinigun
reviewed
May 15, 2023
Fixes a PVS studio warning newly exposed by enabling opengl for debugger builds.
Fixes a PVS studio warning newly exposed by enabling opengl for debugger builds.
Fixes a PVS studio warning newly exposed by enabling opengl for debugger builds.
Fixes a PVS studio warning newly exposed by enabling opengl for debugger builds.
2d4641e to
d532cf6
Compare
GranMinigun
approved these changes
May 16, 2023
Member
Author
|
@GranMinigun , thanks for the checks. Will merge this after the integer PR goes in. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that @GranMinigun has fixed OpenGL when used with the debugger, this PR reverts the exclusion of OpenGL in debugger builds.