Fix regression in palettized VGA line draw function#2491
Merged
Conversation
johnnovak
reviewed
May 17, 2023
johnnovak
approved these changes
May 17, 2023
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2488. Thanks for flagging this @Burrito78.
Had to revert to the
vgaonlyinstance of this function (where it contains separate code paths for the wrapped and unwrapped portions), and then re-added the address and palette iterators like in the (now gone) lamda version.Included notes on how the code can be exercised in case this code gets touched again.