Skip to content

Copy only the available command line chars#2542

Merged
kcgen merged 1 commit intodosbox-staging:mainfrom
LowLevelMahn:llm_copy_too_much
May 29, 2023
Merged

Copy only the available command line chars#2542
kcgen merged 1 commit intodosbox-staging:mainfrom
LowLevelMahn:llm_copy_too_much

Conversation

@LowLevelMahn
Copy link
Copy Markdown
Contributor

Prevent buffer overflow or MSVC STL assert on overflow

@kcgen kcgen added the bug Something isn't working label May 29, 2023
@kcgen kcgen requested review from MeAreJeenius and kcgen May 29, 2023 15:47
Comment thread include/dos_inc.h Outdated
Copy link
Copy Markdown
Member

@kcgen kcgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @LowLevelMahn 🚀

Also, thank you for continuing your tests with the checked STL under MSVC. I will have a follow up PR that turns on some level of equivalent checks for GCC and Clang shortly.

@kcgen kcgen merged commit 129e8c9 into dosbox-staging:main May 29, 2023
@LowLevelMahn LowLevelMahn deleted the llm_copy_too_much branch June 17, 2023 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants