Store envelope channel_name as std::string#2670
Merged
Conversation
johnnovak
reviewed
Jul 9, 2023
johnnovak
approved these changes
Jul 9, 2023
Member
johnnovak
left a comment
There was a problem hiding this comment.
Nice catch @weirddan455, thanks for fixing!
d07bdd4 to
aaa9662
Compare
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found a bug in this envelope class while working on cdrom stuff (almost done btw). It doesn't do a deep copy of its name string so if it gets created with anything besides a string literal, you get random garbage printed out to the debug log.
Pretty simple change to just std::string. It's only used for printing debug text.