Conversation
Add to the list of known good shaders to get rid of the black halo on the edges. Enable sampling in correct color space.
johnnovak
approved these changes
Aug 25, 2023
Member
There was a problem hiding this comment.
Great enhancement @GranMinigun, now it's gamma-correct! 😎
I will experiment with this to use it as the fallback shader for the adaptive CRT shaders instead of sharp. Should only be picked up when we have less than 3 pixels per emulated scanline, so it will give us just the right moderate amount of blur, in theory.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now it samples in the correct colour space. Also added it to the list of well-behaving shaders, so no more black halo on the edges of the output. Comparison, before and after: