Merged
Conversation
1853740 to
5b6932b
Compare
johnnovak
commented
Sep 5, 2023
1a1d4d0 to
75fa71d
Compare
75fa71d to
a6ca874
Compare
a6ca874 to
d36bb34
Compare
Member
Author
|
Done @kcgen , let me know if there's a better way to disable the warning in |
kcgen
approved these changes
Sep 6, 2023
Member
kcgen
left a comment
There was a problem hiding this comment.
Looks good; nice to see more loguru benefits being put to use!
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When it comes to debugging, I'm very much an old-school
printftrace logger type of person (Who needs 'em stinkin' debuggers? Not this guy! 😎)So I've been prefixing my
LOG_MSGstatements with stuff like to>>>>>>>>and!!!!!!!!!and*******to make them stand out from the rest, then started repurposingLOG_ERRandLOG_WARNINGbecause the coloured output makes my debug/trace messages stand out even more.Then today it dawned on me: I can actually make
LOG_DEBUGoutput stuff in a different colour with loguru! I've also seen the light and realised that @weirddan455 was right all along—module-specificDEBUG_MODULNAMEifdefs are the way to go. So I started converting a few modules to that convention as well.Here's how it looks in action with
mixer.cppandvga_draw.cppdebug logging enabled. As you can see, my VGA and mixer debug crap doesn't get drowned in the rest of the crap anymore. Crap stands out, loud and clear—it doesn't get better than that! 😎 🤘🏻...except when it does! 😆 I've also added
LOG_TRACEfor good measure which uses a nice purple colour .