Fix fallback shader scaling for adaptive CRT shaders#2840
Merged
Conversation
Always disable integer scaling in 'integer_scaling = auto' mode for adaptive CRT shaders when the fallback 'sharp' shader is active.
weirddan455
reviewed
Sep 7, 2023
weirddan455
approved these changes
Sep 7, 2023
Collaborator
weirddan455
left a comment
There was a problem hiding this comment.
Seems like a pretty straight forward and small bug fix. Nice job.
Member
Author
Thanks for the review @weirddan455 👍🏻 |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Always disable integer scaling in
integer_scaling = automode for adaptive CRT shaders when the fallbacksharpshader is active.This fixes a rather obscure bug that manifests when:
glshader = crt-auto-*)integer_scaling = automode is selectedsharpshader is active because the minimum vertical scaling ratio requirement hasn't been met