Skip to content

Fix incorrect version reporting in Virtualbox LOG_WARNING.#3002

Merged
kcgen merged 1 commit intomainfrom
wd/virtualbox
Oct 14, 2023
Merged

Fix incorrect version reporting in Virtualbox LOG_WARNING.#3002
kcgen merged 1 commit intomainfrom
wd/virtualbox

Conversation

@weirddan455
Copy link
Copy Markdown
Collaborator

Description

Found by Coverity. This is clearly wrong. It's trying to do a bitwise AND mask of the bottom 16 bits but was incorrectly using a logical and.

Related issues

#2996

Manual testing

It builds

Checklist

Please tick the items as you have addressed them. Don't remove items; leave the ones that are not applicable unchecked.

I have:

  • followed the project's contributing guidelines and code of conduct.
  • performed a self-review of my code.
  • commented on the particularly hard-to-understand areas of my code.
  • split my work into well-defined, bisectable commits, and I named my commits well.
  • applied the appropriate labels (bug, enhancement, refactoring, documentation, etc.)
  • checked that all my commits can be built.
  • confirmed that my code does not cause performance regressions (e.g., by running the Quake benchmark).
  • added unit tests where applicable to prove the correctness of my code and to avoid future regressions.
  • made corresponding changes to the documentation or the website according to the documentation guidelines.
  • locally verified my website or documentation changes.

Found by Coverity. This is clearly wrong. It's trying to do a bitwise AND mask
of the bottom 16 bits but was incorrectly using a logical and.
Part of #2996
@weirddan455 weirddan455 added the bug Something isn't working label Oct 14, 2023
@weirddan455 weirddan455 self-assigned this Oct 14, 2023
Copy link
Copy Markdown
Collaborator

@FeralChild64 FeralChild64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, this was a mistake. Thank you for fixing this!

Copy link
Copy Markdown
Member

@kcgen kcgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice quick fix, @weirddan455 !

@kcgen kcgen merged commit 561d218 into main Oct 14, 2023
@kcgen kcgen deleted the wd/virtualbox branch October 14, 2023 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants