Skip to content

Minor string fixes in MIXER command#3072

Merged
FeralChild64 merged 1 commit intomainfrom
fs/mixer-string-fixes-1
Oct 29, 2023
Merged

Minor string fixes in MIXER command#3072
FeralChild64 merged 1 commit intomainfrom
fs/mixer-string-fixes-1

Conversation

@FeralChild64
Copy link
Copy Markdown
Collaborator

Description

Fixes of two minor string issues I noticed during translation:

  • there was a full stop instead of comma in one place
  • if the help message uses 'x', 'c', and 'r' (lowercase), error messages should use the same capitalization

Checklist

I have:

  • followed the project's contributing guidelines and code of conduct.
  • performed a self-review of my code.
  • commented on the particularly hard-to-understand areas of my code.
  • split my work into well-defined, bisectable commits, and I named my commits well.
  • applied the appropriate labels (bug, enhancement, refactoring, documentation, etc.)
  • checked that all my commits can be built.
  • confirmed that my code does not cause performance regressions (e.g., by running the Quake benchmark).
  • added unit tests where applicable to prove the correctness of my code and to avoid future regressions.
  • made corresponding changes to the documentation or the website according to the documentation guidelines.
  • locally verified my website or documentation changes.

@FeralChild64 FeralChild64 added bug Something isn't working translation Issues related to translations labels Oct 29, 2023
@FeralChild64 FeralChild64 self-assigned this Oct 29, 2023
Comment thread src/dos/program_mixer.cpp
Copy link
Copy Markdown
Member

@johnnovak johnnovak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @FeralChild64 👍🏻

@FeralChild64 FeralChild64 merged commit 4777547 into main Oct 29, 2023
@delete-merged-branch delete-merged-branch Bot deleted the fs/mixer-string-fixes-1 branch October 29, 2023 23:28
@johnnovak johnnovak added the audio Audio related issues or enhancements label Dec 11, 2023
@johnnovak johnnovak changed the title Minor string fixes in 'MIXER' command Minor string fixes in MIXER command Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

audio Audio related issues or enhancements bug Something isn't working translation Issues related to translations

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants