Conversation
Fixes a bug where the Dosbox window will not close while the window is inactive and Dosbox is paused.
4 tasks
pause_when_inactive = true
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Quick fix for a bug I just encountered. To reproduce:
[sdl], setpause_when_inactive=true(this setting does not properly change at runtime, must be set in config).This fix simply checks if shutdown has been requested and, if so, breaks out of the "pause loop". This is the same way that the
PauseDOSBoxfunction handles this.PauseDOSBoxis the code that gets run when you press ALT+Pause on the keyboard.pause_when_inactiveis handled separately in the code touched by this PR.Related issues
No known issues filed. Was quicker for me to just make this PR.
Manual testing
Followed repo steps above and confirmed this fixes the issue. Also confirmed the pausing functionality still works.
Checklist
Please tick the items as you have addressed them. Don't remove items; leave the ones that are not applicable unchecked.
I have: