-
Notifications
You must be signed in to change notification settings - Fork 96
Comparing changes
Open a pull request
base repository: facebook/ktfmt
base: v0.52
head repository: facebook/ktfmt
compare: v0.53
- 14 commits
- 37 files changed
- 8 contributors
Commits on Aug 23, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 8b8d5fc - Browse repository at this point
Copy the full SHA 8b8d5fcView commit details -
Bump version to 1.0.0-SNAPSHOT
Summary: This is the `hg graft --force D61225832` Reviewed By: strulovich Differential Revision: D61539330 fbshipit-source-id: f32e930fe25625fdc641c6231442cfba3e062b13
Configuration menu - View commit details
-
Copy full SHA for fb470b0 - Browse repository at this point
Copy the full SHA fb470b0View commit details -
Summary: Add line for IJ plugin settings change in 1.2.0.52 CC cortinico Pull Request resolved: #509 Reviewed By: strulovich Differential Revision: D61545658 Pulled By: cortinico fbshipit-source-id: ab77e8f5fb5a57c8b389294c695508fa21dc8a91
Configuration menu - View commit details
-
Copy full SHA for 6b7ca01 - Browse repository at this point
Copy the full SHA 6b7ca01View commit details -
Summary: `FormattingOptions#maxWidth` is not respected for double slash comments. This is because it wasn't using the supplied value, and instead checked against the static property `com.google.googlejavaformat.java.Formatter.MAX_LINE_LENGTH`. I was unable to find any documentation / discussion that would indicate this as being intentional. Test cases that deduced `maxWidth` actually relied on this behavior in some cases. Some of the fixes in 84dbfae simply adjusted the number of `/`, while others relied on a specific `maxWidth` and so I manually line-broke the comments to preserve the behavior under test. Pull Request resolved: #511 Reviewed By: strulovich Differential Revision: D61711870 Pulled By: hick209 fbshipit-source-id: d27479c17f68d376c14722a8d3997ea602cfe723
Configuration menu - View commit details
-
Copy full SHA for 5ff9fbb - Browse repository at this point
Copy the full SHA 5ff9fbbView commit details
Commits on Aug 26, 2024
-
bump nexus-staging-maven plugin to 1.7.0 (#507)
Summary: 1.6.13 does not work with jdk 17 which is needed on CI now for the idea build. I hope this works because I can not really test it locally. Pull Request resolved: #507 Reviewed By: cgrushko Differential Revision: D61711839 Pulled By: hick209 fbshipit-source-id: 90c2f3fd3c5c7feb0178e9aff9886dd5a0d1b872
Configuration menu - View commit details
-
Copy full SHA for 9016eae - Browse repository at this point
Copy the full SHA 9016eaeView commit details
Commits on Aug 27, 2024
-
Summary: Make sure to include changes from recent PR Reviewed By: cortinico Differential Revision: D61720374 fbshipit-source-id: 39e942b863163ab56475259221bc46f13b13ebfa
Configuration menu - View commit details
-
Copy full SHA for 667336f - Browse repository at this point
Copy the full SHA 667336fView commit details -
Bump nexus-staging-maven-plugin to 1.7.0 also inside core/
Summary: This follows up the bump for nexus-staging-maven-plugin to 1.7.0 Reviewed By: hick209 Differential Revision: D61846862 fbshipit-source-id: ae83b0eac4c6c66a02bed7a4c194be1669a1a1d1
Configuration menu - View commit details
-
Copy full SHA for aa4fc71 - Browse repository at this point
Copy the full SHA aa4fc71View commit details
Commits on Aug 28, 2024
-
Fix MVN plugin spotless version
Summary: For the maven plugin we have to specify the version of the Maven plugin, not the Gradle one (6.25.0). Reviewed By: cortinico Differential Revision: D61910932 fbshipit-source-id: a3f2a504dce18b46ac891bf13f6d855081277999
Configuration menu - View commit details
-
Copy full SHA for aa5156a - Browse repository at this point
Copy the full SHA aa5156aView commit details -
Summary: Formatting of `pom.xml`, nothing else was done here Reviewed By: cortinico Differential Revision: D61910975 fbshipit-source-id: 2c360df269ba8892334271be52e9934170601ad2
Configuration menu - View commit details
-
Copy full SHA for c3dc022 - Browse repository at this point
Copy the full SHA c3dc022View commit details -
Run spotless as part of our build checks
Reviewed By: cortinico Differential Revision: D61911566 fbshipit-source-id: c9c7c07a68db786982f7993d46176d75d5d0a77e
Configuration menu - View commit details
-
Copy full SHA for 9154b36 - Browse repository at this point
Copy the full SHA 9154b36View commit details
Commits on Aug 30, 2024
-
Workaround non-null parent requirement of StubBase (#513)
Summary: Pull Request resolved: #513 Reviewed By: davidtorosyan Differential Revision: D61870580 Pulled By: hick209 fbshipit-source-id: 046a133a61355fd3a16dd9c92bb803e5b791f60e
Configuration menu - View commit details
-
Copy full SHA for 9dcd261 - Browse repository at this point
Copy the full SHA 9dcd261View commit details
Commits on Sep 3, 2024
-
Summary: After having turned on our internal Android Lint in ktfmt code, here's the code clean up round from it Reviewed By: strulovich Differential Revision: D61979521 fbshipit-source-id: 5182acacb7be7f30770d90e2f8983a649821e138
Configuration menu - View commit details
-
Copy full SHA for 9830466 - Browse repository at this point
Copy the full SHA 9830466View commit details
Commits on Oct 12, 2024
-
Update google-java-format to 1.23.0
Summary: X-link: facebook/react-native#46860 Pulling library into our repository Result of: arc artificer download com.google.googlejavaformat:google-java-format:1.23.0 --interactive Deps ``` ➜ arc artificer rquery dependencies --cross-reference com.google.googlejavaformat:google-java-format:1.23.0 com.google.googlejavaformat:google-java-format:1.23.0 ✅ └╼ com.google.guava:guava:32.1.3-jre:compile ✅ ``` Formatted with ``` tools/arcanist/lint/codemods/googlejavaformat_fbsource ``` Reviewed By: hick209 Differential Revision: D60787993 fbshipit-source-id: dbadc5184c0a7cccd967173e21602657013ddac7
Configuration menu - View commit details
-
Copy full SHA for ed949e8 - Browse repository at this point
Copy the full SHA ed949e8View commit details
Commits on Oct 30, 2024
-
Reviewed By: cortinico Differential Revision: D65207755 fbshipit-source-id: 8daaed9c40e5d1f5cdf51a21316263663651ecdb
Configuration menu - View commit details
-
Copy full SHA for 8ab3bf6 - Browse repository at this point
Copy the full SHA 8ab3bf6View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v0.52...v0.53