Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: facebook/ktfmt
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.52
Choose a base ref
...
head repository: facebook/ktfmt
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.53
Choose a head ref
  • 14 commits
  • 37 files changed
  • 8 contributors

Commits on Aug 23, 2024

  1. Revert "Bump braces and gulp in /website (#480)" (#508)

    Summary:
    This reverts commit 06db714.
    
    Gulp 5.0.0 broke the website generation so I'm reverting this change for now
    
    Pull Request resolved: #508
    
    Reviewed By: strulovich
    
    Differential Revision: D61539181
    
    Pulled By: cortinico
    
    fbshipit-source-id: 6347db91262eb57e243a490c518f62f58ec86a86
    ktfmt authored and facebook-github-bot committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    8b8d5fc View commit details
    Browse the repository at this point in the history
  2. Bump version to 1.0.0-SNAPSHOT

    Summary: This is the `hg graft --force D61225832`
    
    Reviewed By: strulovich
    
    Differential Revision: D61539330
    
    fbshipit-source-id: f32e930fe25625fdc641c6231442cfba3e062b13
    cortinico authored and facebook-github-bot committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    fb470b0 View commit details
    Browse the repository at this point in the history
  3. Update CHANGELOG.md (#509)

    Summary:
    Add line for IJ plugin settings change in 1.2.0.52
    
    CC cortinico
    
    Pull Request resolved: #509
    
    Reviewed By: strulovich
    
    Differential Revision: D61545658
    
    Pulled By: cortinico
    
    fbshipit-source-id: ab77e8f5fb5a57c8b389294c695508fa21dc8a91
    rock3r authored and facebook-github-bot committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    6b7ca01 View commit details
    Browse the repository at this point in the history
  4. fix: comment max width (#511)

    Summary:
    `FormattingOptions#maxWidth` is not respected for double slash comments. This is because it wasn't using the supplied value, and instead checked against the static property `com.google.googlejavaformat.java.Formatter.MAX_LINE_LENGTH`. I was unable to find any documentation / discussion that would indicate this as being intentional.
    
    Test cases that deduced `maxWidth` actually relied on this behavior in some cases. Some of the fixes in 84dbfae simply adjusted the number of `/`, while others relied on a specific `maxWidth` and so I manually line-broke the comments to preserve the behavior under test.
    
    Pull Request resolved: #511
    
    Reviewed By: strulovich
    
    Differential Revision: D61711870
    
    Pulled By: hick209
    
    fbshipit-source-id: d27479c17f68d376c14722a8d3997ea602cfe723
    rileymichael authored and facebook-github-bot committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    5ff9fbb View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2024

  1. bump nexus-staging-maven plugin to 1.7.0 (#507)

    Summary:
    1.6.13 does not work with jdk 17 which is needed on CI now for the idea build.
    
    I hope this works because I can not really test it locally.
    
    Pull Request resolved: #507
    
    Reviewed By: cgrushko
    
    Differential Revision: D61711839
    
    Pulled By: hick209
    
    fbshipit-source-id: 90c2f3fd3c5c7feb0178e9aff9886dd5a0d1b872
    christophsturm authored and facebook-github-bot committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    9016eae View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2024

  1. Update changelog

    Summary: Make sure to include changes from recent PR
    
    Reviewed By: cortinico
    
    Differential Revision: D61720374
    
    fbshipit-source-id: 39e942b863163ab56475259221bc46f13b13ebfa
    Nivaldo Bondança authored and facebook-github-bot committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    667336f View commit details
    Browse the repository at this point in the history
  2. Bump nexus-staging-maven-plugin to 1.7.0 also inside core/

    Summary: This follows up the bump for nexus-staging-maven-plugin to 1.7.0
    
    Reviewed By: hick209
    
    Differential Revision: D61846862
    
    fbshipit-source-id: ae83b0eac4c6c66a02bed7a4c194be1669a1a1d1
    cortinico authored and facebook-github-bot committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    aa4fc71 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2024

  1. Fix MVN plugin spotless version

    Summary: For the maven plugin we have to specify the version of the Maven plugin, not the Gradle one (6.25.0).
    
    Reviewed By: cortinico
    
    Differential Revision: D61910932
    
    fbshipit-source-id: a3f2a504dce18b46ac891bf13f6d855081277999
    Nivaldo Bondança authored and facebook-github-bot committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    aa5156a View commit details
    Browse the repository at this point in the history
  2. Apply Spotless to pom.xml

    Summary: Formatting of `pom.xml`, nothing else was done here
    
    Reviewed By: cortinico
    
    Differential Revision: D61910975
    
    fbshipit-source-id: 2c360df269ba8892334271be52e9934170601ad2
    Nivaldo Bondança authored and facebook-github-bot committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    c3dc022 View commit details
    Browse the repository at this point in the history
  3. Run spotless as part of our build checks

    Reviewed By: cortinico
    
    Differential Revision: D61911566
    
    fbshipit-source-id: c9c7c07a68db786982f7993d46176d75d5d0a77e
    Nivaldo Bondança authored and facebook-github-bot committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    9154b36 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2024

  1. Workaround non-null parent requirement of StubBase (#513)

    Summary: Pull Request resolved: #513
    
    Reviewed By: davidtorosyan
    
    Differential Revision: D61870580
    
    Pulled By: hick209
    
    fbshipit-source-id: 046a133a61355fd3a16dd9c92bb803e5b791f60e
    jsjeon authored and facebook-github-bot committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    9dcd261 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2024

  1. Lint code clean up

    Summary: After having turned on our internal Android Lint in ktfmt code, here's the code clean up round from it
    
    Reviewed By: strulovich
    
    Differential Revision: D61979521
    
    fbshipit-source-id: 5182acacb7be7f30770d90e2f8983a649821e138
    Nivaldo Bondança authored and facebook-github-bot committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    9830466 View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2024

  1. Update google-java-format to 1.23.0

    Summary:
    X-link: facebook/react-native#46860
    
    Pulling library into our repository
    
    Result of:
      arc artificer download com.google.googlejavaformat:google-java-format:1.23.0 --interactive
    
    Deps
    ```
    ➜  arc artificer rquery dependencies --cross-reference com.google.googlejavaformat:google-java-format:1.23.0
    com.google.googlejavaformat:google-java-format:1.23.0 ✅
    └╼ com.google.guava:guava:32.1.3-jre:compile ✅
    
    ```
    
    Formatted with
    
    ```
    tools/arcanist/lint/codemods/googlejavaformat_fbsource
    ```
    
    Reviewed By: hick209
    
    Differential Revision: D60787993
    
    fbshipit-source-id: dbadc5184c0a7cccd967173e21602657013ddac7
    j-bahr authored and facebook-github-bot committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    ed949e8 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2024

  1. Bump version to 0.53

    Reviewed By: cortinico
    
    Differential Revision: D65207755
    
    fbshipit-source-id: 8daaed9c40e5d1f5cdf51a21316263663651ecdb
    Nivaldo Bondança authored and facebook-github-bot committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    8ab3bf6 View commit details
    Browse the repository at this point in the history
Loading