Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: facebook/ktfmt
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.54
Choose a base ref
...
head repository: facebook/ktfmt
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.55
Choose a head ref
  • 12 commits
  • 37 files changed
  • 4 contributors

Commits on Jan 15, 2025

  1. Bump version to 0.55-SNAPSHOT

    Reviewed By: cortinico
    
    Differential Revision: D68211751
    
    fbshipit-source-id: 46dd1575178dca88814d97e00757cc329541ebae
    Nivaldo Bondança authored and facebook-github-bot committed Jan 15, 2025
    Configuration menu
    Copy the full SHA
    9da9a38 View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2025

  1. Bump Kotlin to 2.0.21

    Summary: This just keeps Kotlin updated to the latest patch version in the 2.0.x series.
    
    Reviewed By: strulovich
    
    Differential Revision: D68266000
    
    fbshipit-source-id: 97d3fa002c72c2f27e1bed420dc5cbbaeac3fa52
    cortinico authored and facebook-github-bot committed Jan 16, 2025
    Configuration menu
    Copy the full SHA
    bcec853 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2025

  1. Support guard conditions (#537)

    Summary:
    Resolves #530
    
    Pull Request resolved: #537
    
    Reviewed By: navidqar
    
    Differential Revision: D74476924
    
    Pulled By: hick209
    
    fbshipit-source-id: afc8599b723f9a9f808d68b1a35a9ae81c07ced3
    ZacSweers authored and facebook-github-bot committed May 10, 2025
    Configuration menu
    Copy the full SHA
    e02804d View commit details
    Browse the repository at this point in the history
  2. Update Kotlin to 2.2.0-Beta2 (#538)

    Summary:
    Ref: #536 (comment)
    
    Pull Request resolved: #538
    
    Reviewed By: navidqar
    
    Differential Revision: D74494969
    
    Pulled By: hick209
    
    fbshipit-source-id: 7db3b1339f2b359f518a2fb56db0b7631a522026
    ZacSweers authored and facebook-github-bot committed May 10, 2025
    Configuration menu
    Copy the full SHA
    cca92e5 View commit details
    Browse the repository at this point in the history

Commits on May 20, 2025

  1. Fix option in .editorconfig-default (#543) (#544)

    Summary:
    See context on #543.
    
    Pull Request resolved: #544
    
    Differential Revision: D75077460
    
    Pulled By: hick209
    
    fbshipit-source-id: fc8d8ad998de112dedfc75c3d3625c7ac79fccf9
    patricklucas authored and facebook-github-bot committed May 20, 2025
    Configuration menu
    Copy the full SHA
    b83eb4e View commit details
    Browse the repository at this point in the history
  2. Gradle

    Summary:
    Migrated ktfmt to Gradle.
    
    Keeping `pom.xml` around just in case something goes wrong, so we have a simple and easy fallback/revert to what we know works.
    
    Reviewed By: strulovich
    
    Differential Revision: D75067564
    
    fbshipit-source-id: b6cbadfd24f7763151bf0e00d9f6f7e86f7c85ad
    Nivaldo Bondança authored and facebook-github-bot committed May 20, 2025
    Configuration menu
    Copy the full SHA
    d03a29e View commit details
    Browse the repository at this point in the history
  3. Support context parameters (#536)

    Summary:
    Resolves #518
    
    Note that in order for `LightVirtualFile` to correctly parse this, it did require updating to the Kotlin 2.2.0 betas. Since this ships as a fat jar I think it would be fine to build against this in `main`, but up to y'all!
    
    This adds a couple new tests for it + ensures backward compatibility with the previous context receivers syntax.
    
    Pull Request resolved: #536
    
    Reviewed By: cortinico, strulovich
    
    Differential Revision: D74587694
    
    Pulled By: hick209
    
    fbshipit-source-id: 2250209265372a74f55a0f1a3767d0df25c28171
    ZacSweers authored and facebook-github-bot committed May 20, 2025
    Configuration menu
    Copy the full SHA
    2ec130a View commit details
    Browse the repository at this point in the history

Commits on May 21, 2025

  1. Remove unnecessary gradle setup

    Summary: Turns out this is not really necessary as the plugin already sets up these dependency chain.
    
    Reviewed By: cortinico
    
    Differential Revision: D75097474
    
    fbshipit-source-id: bbf49836f1482dfcd8e106b61243c15dece76fba
    Nivaldo Bondança authored and facebook-github-bot committed May 21, 2025
    Configuration menu
    Copy the full SHA
    a79e1af View commit details
    Browse the repository at this point in the history
  2. Fix buck builds

    Summary:
    whoopsie
    
    Luckily this task here T224956699 flagged that I forgot to touch the test buck files in D75067564. The Gradle build told me the tests  were good so I trusted that, which was not wrong, only our buck builds were broken.
    
    Fixed them here!
    
    Reviewed By: cortinico
    
    Differential Revision: D75101250
    
    fbshipit-source-id: be98d8f738b748101076ae71e8c54420249da16f
    Nivaldo Bondança authored and facebook-github-bot committed May 21, 2025
    Configuration menu
    Copy the full SHA
    abd0a44 View commit details
    Browse the repository at this point in the history
  3. Fix gradle scripted builds

    Summary:
    Issue:
    https://github.com/facebook/ktfmt/actions/runs/15147530441/job/42586736383#step:4:28
    
    Repro:
    ```
    cd xplat/ktfmt
    ./gradlew clean
    ./gradlew :ktfmt:build
    ```
    
    Fix:
    ```
    ./gradlew :ktfmt:compileKotlin
    # now this will pass too
    ./gradlew :ktfmt:build
    ```
    
    It turns that if we compile any of the other projects before the main one, then it compiles fine afterwards, which I guess means that ktfmt-gradle was compiled and is now available.
    
    I don't fully understand what is going on here, but I'm glad this will help us stop the bleeding.
    
    Differential Revision: D75134683
    
    fbshipit-source-id: 1ec57fab4f49d130e591d31363caac7358699eaa
    Nivaldo Bondança authored and facebook-github-bot committed May 21, 2025
    Configuration menu
    Copy the full SHA
    ac3a3c0 View commit details
    Browse the repository at this point in the history
  4. Output version CLI option

    Summary: As requested in #534
    
    Reviewed By: cortinico
    
    Differential Revision: D75131149
    
    fbshipit-source-id: 249b7f3a3ec1a4b8a0be33a581b07ace12cd08b8
    Nivaldo Bondança authored and facebook-github-bot committed May 21, 2025
    Configuration menu
    Copy the full SHA
    d4082fd View commit details
    Browse the repository at this point in the history
  5. Bump version to 0.55

    Reviewed By: strulovich
    
    Differential Revision: D75152279
    
    fbshipit-source-id: 33faf5912b48c15129c7ced14337b71a4cf6f428
    Nivaldo Bondança authored and facebook-github-bot committed May 21, 2025
    Configuration menu
    Copy the full SHA
    512e16c View commit details
    Browse the repository at this point in the history
Loading