Make sure 'mu' and 'std' are not numpy floats #2378
Conversation
|
Hi @lior1990! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
pandas strikes again 😂 Thanks for the fix, I'll kick off CI and it should be good to merge after that. |
|
One test is failing due to the same issue as in #2401 (comment) |
Hi,
I encountered a similar issue like #1824, where the target value (i.e.
y) was np.float32, then the computedy_scalewas np.float32 as well, which caused json serialization to fail.In my scenario, the extra regressors were np.float32, so
muandstdare also np.float32 and I'm unable to serialize the model (of course after callingmodel_to_dict).The solution is just to convert it to float, same as in 9e4e87a.
Thanks!