Unset SYSTEMD_COLORS for systemd completion #11465
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an issue where systemctl and other systemd commands completions are prefixed by ANSI color escape codes
Member
|
Thank you! |
Contributor
|
nix should allow you to run
only the value in the inner scope matters: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue where systemctl and other systemd commands completions are prefixed by ANSI color escape codes
TODOs:
Notes:
Since dependencies has changed an Nix is a bit finicky with cargoHashes and stuff I cloned 4.0.2 which I'm currently using and applied this patch which i then cherry picked to master, but considering the change is only in fish code it should be irrelevant.
It was a bit unclear from the documentation if
set -luwould work without unexporting the variable for the running shell but tests on my machine keeps SYSTEMD_COLORS=true in my shell.Last minute thing: Should i use set -lu or set -fu?