Improve / Update french translation #11842

milouse · 2025-09-30T12:30:00Z

Description

I’m working on a big review/update of the french translation. As the po file was not edited in a while, there are lot of missing translation. I’d like to address them all before asking for merge. However I open now this MR if anyone else speaking french would like to begin the review :)

Fixes issue #

TODOs:

Changes to fish usage are reflected in user documentation/manpages.
Tests have been added for regressions fixed
User-visible changes noted in CHANGELOG.rst

danielrainer · 2025-09-30T23:59:05Z

This PR made me notice that our error handling for invalid syntax in PO files is not great. I opened #11847, #11848, and #11849 to address that. If they are merged into master, rebasing your branch on top of that might make it more convenient to spot errors.

po/fr.po

krobelus · 2025-10-11T12:06:26Z

is this ready for review (in other words, could we merge it as far as you're concerned)?

milouse · 2025-10-17T19:00:06Z

is this ready for review (in other words, could we merge it as far as you're concerned)?

Yes sorry. I just rebased my branch on the latest master, fixing some of your previous comments in the move. I’ll stop for now and push later a new PR with more changes. But for now this one is ready.

To be honest, the aim of this PR was also to test the community to check whereas there was any other french people interested to help, and how fast/welcoming are the current maintainers. On the later case, I’m very glad to see how fast and warm you were from the beginning. It’s very pleasant to help with nice people around :) Thank you very much!

krobelus · 2025-10-17T19:35:07Z

Maybe @PenegalECI or @moverest want to review but otherwise I'm also happy to merge in a week or so

moverest · 2025-10-19T20:46:47Z

po/fr.po

 #, c-format
 msgid "%s could not read response to Primary Device Attribute query after waiting for %d seconds. This is often due to a missing feature in your terminal. See 'help terminal-compatibility' or 'man fish-terminal-compatibility'. This %s process will no longer wait for outstanding queries, which disables some optional features."
-msgstr ""
+msgstr "%s n’a pas pu lire de réponse à une requête « Primary Device Attribute » après avoir attendu %d secondes. Ceci est souvent du à une fonctionnalité manquante de votre terminal. Voir « help terminal-compatibility » ou « man fish-terminal-compatibility ». Le processus %s va désormais ignorer les requêtes importantes, ce qui va désactiver quelques fonctionnalités optionnelles."


Suggested change

msgstr "%s n’a pas pu lire de réponse à une requête « Primary Device Attribute » après avoir attendu %d secondes. Ceci est souvent du à une fonctionnalité manquante de votre terminal. Voir « help terminal-compatibility » ou « man fish-terminal-compatibility ». Le processus %s va désormais ignorer les requêtes importantes, ce qui va désactiver quelques fonctionnalités optionnelles."

msgstr "%s n’a pas pu lire de réponse à une requête « Primary Device Attribute » après avoir attendu %d secondes. Ceci est souvent dû à une fonctionnalité manquante de votre terminal. Voir « help terminal-compatibility » ou « man fish-terminal-compatibility ». Ce processus %s va désormais ignorer les requêtes en attente, ce qui désactive quelques fonctionnalités optionnelles."

moverest · 2025-10-19T20:49:24Z

po/fr.po

 #, c-format
 msgid "%s: --command cannot be combined with --position=command"
-msgstr ""
+msgstr "%s : --command ne peut pas être utilisé avec l’option --position"


Suggested change

msgstr "%s : --command ne peut pas être utilisé avec l’option --position"

msgstr "%s : --command ne peut pas être utilisé avec l’option --position=command"

Or maybe:

Suggested change

msgstr "%s : --command ne peut pas être utilisé avec l’option --position"

msgstr "%s : --command ne peut pas être utilisé avec l’option --position=commande"

Not sure about the context here to be certain, i.e. if command is the value or just a placeholder.

It’s from the help of abbr command, so it’s a placeholder, which should not be translated.

moverest · 2025-10-19T20:50:26Z

po/fr.po

 #, c-format
 msgid "%s: --function option requires --add\n"
-msgstr ""
+msgstr "%s : l’option --function doit être utilisé avec --add\n"


Suggested change

msgstr "%s : l’option --function doit être utilisé avec --add\n"

msgstr "%s : l’option --function doit être utilisée avec --add\n"

moverest · 2025-10-19T20:50:39Z

po/fr.po

 #, c-format
 msgid "%s: --position option requires --add\n"
-msgstr ""
+msgstr "%s : l’option --position doit être utilisé avec --add\n"


Suggested change

msgstr "%s : l’option --position doit être utilisé avec --add\n"

msgstr "%s : l’option --position doit être utilisée avec --add\n"

moverest · 2025-10-19T20:50:53Z

po/fr.po

 #, c-format
 msgid "%s: --regex option requires --add\n"
-msgstr ""
+msgstr "%s : l’option --regex doit être utilisé avec --add\n"


Suggested change

msgstr "%s : l’option --regex doit être utilisé avec --add\n"

msgstr "%s : l’option --regex doit être utilisée avec --add\n"

And the rest as I don't want to spam with messages... Maybe we should also do that when it says %s: --something doit être utilisé without using the "option" word as it is implied. 🤷

moverest · 2025-10-19T20:54:28Z

po/fr.po

 #, c-format
 msgid "%s: Did you mean `set %s %s`?"
-msgstr ""
+msgstr "%s : Vouliez-vous dire `set %s %s` ?"


Nitpicking: there might be an argument with using « » instead.

This is something I’m not sure… some messages use single quote in the source string, others use double quote, other backtick… As I didn’t know if there was a specific reason or not for the backtick, I assume it was on purpose. That’s why I kept them in the translation, contrary to the single or double quotes I replace by «».

I think in most cases it's primarily personal preference of whoever wrote the code. I am not particular consistent with quote usage myself. One possible consideration might be that certain quotes are more likely to appear in the arguments to the format string, so using different ones is better for clearly delimiting the string. French quotes should not be affected by this problem, since I'm fairly confident that the only situation where the string arguments might contain such quotes is when they are taken from user input, and in such cases it could easily contain any of the other quotes as well. So I think it's fine to replace backtick quotes as well.

The way I see it is that the ` is used the same way it is in a Markdown document — i.e. for code — but it doesn't look to be consistent. Sometimes " and ' are used instead which are here replace with « ».

I don't think it's important either way thus the way I've worded this suggestion. If it's really an issue, the inconsistency is probably something that's more interesting to address in the original strings first.

milouse · 2025-10-20T12:27:06Z

Thanks for the review, I’ll do the fix ASAP

milouse · 2025-10-21T19:12:01Z

Hi again, and thank you for the reviews.

I just rebase the branch on latest master and answer your proposals in the latest commit. Let me know if you think about something else.

krobelus · 2025-10-22T07:33:00Z

po/fr.po


 msgid "Information request"
-msgstr "Demande d'information"
+msgstr "Demande d’information"


FWIW in future, it might be beneficial, to put global (but simple) changes such as punctuation changes into a separate commit, to make it easier to review.

Part of #11842

Machou · 2025-11-10T14:53:12Z

Je travaille actuellement sur une importante révision/mise à jour de la traduction française. Le fichier PO n'ayant pas été modifié depuis un certain temps, de nombreuses traductions manquent. Je souhaite toutes les corriger avant de demander la fusion. J'ouvre donc cette demande de fusion dès maintenant ; si d'autres francophones souhaitent participer à la révision, n'hésitez pas !

Le fichier en.po contient 79263 lignes.

On peut facilement dire qu'il y a un message toutes les 3 lignes, ça fait 26421 messages à traduire.

Courage.

Si j'ai du temps je passerai faire un tour pour aider.

milouse force-pushed the french-translation branch 2 times, most recently from 1de645b to df7b927 Compare September 30, 2025 12:49

krobelus reviewed Oct 1, 2025

View reviewed changes

po/fr.po Outdated Show resolved Hide resolved

po/fr.po Outdated Show resolved Hide resolved

po/fr.po Outdated Show resolved Hide resolved

po/fr.po Outdated Show resolved Hide resolved

po/fr.po Show resolved Hide resolved

faho added the translations label Oct 2, 2025

milouse force-pushed the french-translation branch 2 times, most recently from a8a3df1 to 4dc39b9 Compare October 2, 2025 19:58

This was referenced Oct 4, 2025

sprintf: add support for explicit arg positions #11857

Draft

French translation #11879

Closed

milouse force-pushed the french-translation branch from 4dc39b9 to 70527fc Compare October 6, 2025 10:34

krobelus marked this pull request as draft October 6, 2025 12:59

milouse force-pushed the french-translation branch 2 times, most recently from e5b6c69 to cb02632 Compare October 17, 2025 18:51

milouse changed the title ~~[DRAFT] Improve / Update french translation~~ Improve / Update french translation Oct 17, 2025

milouse marked this pull request as ready for review October 17, 2025 19:00

moverest reviewed Oct 19, 2025

View reviewed changes

Sort recommended translations in french po file

fc24c7d

milouse force-pushed the french-translation branch from cada8e2 to bee3d75 Compare October 21, 2025 18:33

milouse added 4 commits October 21, 2025 21:10

Improve some french translations

60c7d9a

Add me as french maintainer

f74d64d

Avoid a crash in ubuntu CI

e7d05dd

Improve french translation following review

00bffcd

milouse force-pushed the french-translation branch from bee3d75 to 00bffcd Compare October 21, 2025 19:10

krobelus reviewed Oct 22, 2025

View reviewed changes

krobelus added this to the fish 4.2 milestone Oct 22, 2025

krobelus pushed a commit that referenced this pull request Oct 22, 2025

Sort recommended translations in french po file

2dd6a7b

Part of #11842

krobelus closed this in e7e9783 Oct 22, 2025

krobelus pushed a commit that referenced this pull request Oct 22, 2025

Add me as french maintainer

9ccd6fb

Part of #11842

	msgstr "%s : --command ne peut pas être utilisé avec l’option --position"
	msgstr "%s : --command ne peut pas être utilisé avec l’option --position=command"

	msgstr "%s : l’option --function doit être utilisé avec --add\n"
	msgstr "%s : l’option --function doit être utilisée avec --add\n"

	msgstr "%s : l’option --position doit être utilisé avec --add\n"
	msgstr "%s : l’option --position doit être utilisée avec --add\n"

	msgstr "%s : l’option --regex doit être utilisé avec --add\n"
	msgstr "%s : l’option --regex doit être utilisée avec --add\n"

Uh oh!

Improve / Update french translation #11842

Improve / Update french translation #11842

Uh oh!

Conversation

milouse commented Sep 30, 2025

Description

TODOs:

Uh oh!

danielrainer commented Sep 30, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

krobelus commented Oct 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

milouse commented Oct 17, 2025

Uh oh!

krobelus commented Oct 17, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

milouse commented Oct 20, 2025

Uh oh!

milouse commented Oct 21, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Machou commented Nov 10, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

krobelus commented Oct 11, 2025 •

edited

Loading